Feature #11494
openQuotations Module Review & Enhancements — AppForSolar vs RegalSolar
100%
Subtasks
Related issues
Updated by Ramu Kodali 9 days ago
- Status changed from New to Resolved
- % Done changed from 0 to 100
Today i completed comprehensive comparison of the entire quotations module between the RegalSolar and AppForSolar projects, covering both the backend (Node.js/Express) and frontend (React/TypeScript). After reviewing every key file — including the controller, service, routes, schema, email templates, and all frontend pages (Quotations list, Table, QuotationForm, QuotationDetails, CreateQuotation, EditQuotation, and QuotationConfirmation) — we found that AppForSolar already contains all quotation functionality present in RegalSolar, and in several areas is more advanced: the backend controller in AppForSolar is tenant-aware (it looks up the company name from the master database to personalize customer-facing approval pages), the token verification service supports an allowAccepted flag so customers can still upload documents after an admin approves on their behalf, the EditQuotation page has stronger TypeScript typing and a cleaner save-action state machine, and the Table component correctly stops event propagation on copy-to-clipboard buttons (a bug that exists in RegalSolar). Following the comparison, two enhancements were implemented: a minor backend log line (304 Not Modified on /api/projects/getNotifications) was confirmed as normal caching behavior requiring no action, and the Acceptance Deadline column in the quotations table was improved so that once a quotation is accepted, it no longer shows a meaningless countdown or date — instead it now displays "Already Accepted" in green, giving users a clear, contextually appropriate status at a glance.